Fuite mémoire

**Traroth2** · 27/10/2010, 20h01

Suite de mon message d'il y a quelques jours...

J'ai écrit un système de génération de XML en utilisant StAX, et je dois bien dire que mon problème est un problème de fuite mémoire, exactement comme avec la génération JDOM que j'utilisais avant. Je dois préciser que j'ai en grande partie repris mon code JDOM...

Code :

Sélectionner tout - Visualiser dans une fenêtre à part

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
 
package com.pixvisio.icontact.xml;
 
import java.io.OutputStream;
import java.io.Writer;
import java.util.List;
 
import javax.xml.stream.XMLOutputFactory;
import javax.xml.stream.XMLStreamWriter;
 
import org.apache.log4j.Logger;
import org.codehaus.stax2.XMLStreamWriter2;
 
import com.ctc.wstx.stax.WstxOutputFactory;
 
import com.pixvisio.icontact.db.bean.FBConnection;
import com.pixvisio.icontact.db.bean.FBFriend;
import com.pixvisio.icontact.info.FBXAll;
import com.pixvisio.icontact.info.XAll;
 
/**
 * XAll generator written using StAX technology
 *
 */
public class XallGenerator2 {
 
	protected static Logger logger = Logger.getLogger(XallGenerator2.class);
 
	//public static void generate(Writer out, List<FBConnection> fbcs, List<FBFriend> fbfs, List<XAll> xalls) {
	public static void generate(OutputStream out, List<FBConnection> fbcs, List<FBFriend> fbfs, List<XAll> xalls) {
		generate(out, "ISO-8859-1",fbcs, fbfs, xalls);
	}
 
	//public static void generate(Writer out, String encoding, List<FBConnection> fbcs, List<FBFriend> fbfs, List<XAll> xalls) {
	public static void generate(OutputStream out, String encoding, List<FBConnection> fbcs, List<FBFriend> fbfs, List<XAll> xalls) {
		try {
			//XMLEventWriter writer = ((WstxOutputFactory)outputFactory).createXMLEventWriter(out,encoding);
			//XMLEventFactory eventFactory = WstxEventFactory.newInstance();
 
			//WstxOutputFactory outputFactory = new WstxOutputFactory();
			//XMLStreamWriter2 writer =  outputFactory.createXMLStreamWriter(out,encoding);
 
			XMLOutputFactory outputFactory = XMLOutputFactory.newInstance();
			XMLStreamWriter writer =  outputFactory.createXMLStreamWriter(out);
 
			writer.writeStartDocument(encoding,"1.0");
 
			XAll old = null;
 
			writer.writeStartElement("collection");
 
			if (fbcs!=null) {
				writer.writeStartElement("fbconnections");
				for (FBConnection fbc : fbcs) {
					writer.writeEmptyElement("fbc");
					writer.writeAttribute("id",Long.toString(fbc.getId()));
					writer.writeAttribute("fbu",fbc.getFbUserId());
					writer.writeAttribute("name",fbc.getName());
					//writer.writeEndElement(); // fbc
				}
				writer.writeEndElement(); // fbconnections
			}
 
			if (fbfs!=null) {
				writer.writeStartElement("fbfriends");
				for (FBFriend fbf : fbfs) {
					writer.writeEmptyElement("fbf");
					writer.writeAttribute("id",Long.toString(fbf.getId()));
					writer.writeAttribute("fbu",fbf.getFbUserId());
					writer.writeAttribute("fbc",Long.toString(fbf.getFbConnection()));
					writer.writeAttribute("name",fbf.getName());
					//writer.writeEndElement(); // fbf
				}
				writer.writeEndElement(); // fbfriends
			}
 
			for (XAll current : xalls) {
				if (old == null) {
					writer.writeStartElement("user");
					writer.writeAttribute("compteId", current.getCompteId());
					writer.writeAttribute("name", current.getCompleteUserName());
					writer.writeAttribute("login", current.getLogin());
 
					if (current.getFolderId()!=null && !current.getFolderId().equals("")) {
						writer.writeStartElement("folder");
						writer.writeAttribute("name", current.getFolderName());
						writer.writeAttribute("id", current.getFolderId());
						writer.writeAttribute("shared", current.getFolderShared());
						writer.writeAttribute("folderKeyCode", current.getFolderKeycode());
						if (current instanceof FBXAll) {
							writer.writeAttribute("fbc", ((FBXAll)current).getFbConnection());
							writer.writeAttribute("fbrw", ((FBXAll)current).getFbReadWrite());
							if (((FBXAll)current).getFbFriend()!=null && !((FBXAll)current).getFbFriend().equals((""))) {
								writer.writeAttribute("fbf", ((FBXAll)current).getFbFriend());
							}
						}
 
						if (current.getPhotoId()!=null && !current.getPhotoId().equals("")) {
							writer.writeEmptyElement("version");
							writer.writeAttribute("i", current.getPhotoVersionId());
							writer.writeAttribute("pi", current.getPhotoId());
							writer.writeAttribute("pud", current.getPhotoOriginalUploadDate());
							writer.writeAttribute("pvd", current.getPhotoVersionUploadDate());
							writer.writeAttribute("ptd", current.getPhotoTakeDate());
							if (current.getPhotoVersionFileName()!=null && !current.getPhotoVersionFileName().equals("")) {
								writer.writeAttribute("fn", current.getPhotoVersionFileName());
							}
							if (current.getPhotoVersionPictureName()!=null && !current.getPhotoVersionPictureName().equals("")) {
								writer.writeAttribute("n", current.getPhotoVersionPictureName());
							}
							writer.writeAttribute("pkc", current.getPhotoVersionKeyCode());
							writer.writeAttribute("s", current.getPhotoVersionSize());
							writer.writeAttribute("w", current.getPhotoVersionWidth());
							writer.writeAttribute("h", current.getPhotoVersionHeight());
							writer.writeAttribute("o", "1");
							//writer.writeEndElement(); // version
						}
					}
				} else if (current.getCompteId().equals(old.getCompteId())) {
					if (current.getFolderId().equals(old.getFolderId())) {
						writer.writeEmptyElement("version");
						writer.writeAttribute("i", current.getPhotoVersionId());
						writer.writeAttribute("pi", current.getPhotoId());
						writer.writeAttribute("pud", current.getPhotoOriginalUploadDate());
						writer.writeAttribute("pvd", current.getPhotoVersionUploadDate());
						writer.writeAttribute("ptd", current.getPhotoTakeDate());
						if (current.getPhotoVersionFileName()!=null && !current.getPhotoVersionFileName().equals("")) {
							writer.writeAttribute("fn", current.getPhotoVersionFileName());
						}
						if (current.getPhotoVersionPictureName()!=null && !current.getPhotoVersionPictureName().equals("")) {
							writer.writeAttribute("n", current.getPhotoVersionPictureName());
						}
						writer.writeAttribute("pkc", current.getPhotoVersionKeyCode());
						writer.writeAttribute("s", current.getPhotoVersionSize());
						writer.writeAttribute("w", current.getPhotoVersionWidth());
						writer.writeAttribute("h", current.getPhotoVersionHeight());
						writer.writeAttribute("o", "1");
						//writer.writeEndElement(); // version
					} else {
						writer.writeEndElement(); // folder
 
						writer.writeStartElement("folder");
						writer.writeAttribute("name", current.getFolderName());
						writer.writeAttribute("id", current.getFolderId());
						writer.writeAttribute("shared", current.getFolderShared());
						writer.writeAttribute("folderKeyCode", current.getFolderKeycode());
						if (current instanceof FBXAll) {
							writer.writeAttribute("fbc", ((FBXAll)current).getFbConnection());
							writer.writeAttribute("fbrw", ((FBXAll)current).getFbReadWrite());
							if (((FBXAll)current).getFbFriend()!=null && !((FBXAll)current).getFbFriend().equals((""))) {
								writer.writeAttribute("fbf", ((FBXAll)current).getFbFriend());
							}
						}
 
						if (current.getPhotoId()!=null && !current.getPhotoId().equals("")) {
							writer.writeEmptyElement("version");
							writer.writeAttribute("i", current.getPhotoVersionId());
							writer.writeAttribute("pi", current.getPhotoId());
							writer.writeAttribute("pud", current.getPhotoOriginalUploadDate());
							writer.writeAttribute("pvd", current.getPhotoVersionUploadDate());
							writer.writeAttribute("ptd", current.getPhotoTakeDate());
							if (current.getPhotoVersionFileName()!=null && !current.getPhotoVersionFileName().equals("")) {
								writer.writeAttribute("fn", current.getPhotoVersionFileName());
							}
							if (current.getPhotoVersionPictureName()!=null && !current.getPhotoVersionPictureName().equals("")) {
								writer.writeAttribute("n", current.getPhotoVersionPictureName());
							}
							writer.writeAttribute("pkc", current.getPhotoVersionKeyCode());
							writer.writeAttribute("s", current.getPhotoVersionSize());
							writer.writeAttribute("w", current.getPhotoVersionWidth());
							writer.writeAttribute("h", current.getPhotoVersionHeight());
							writer.writeAttribute("o", "1");
							//writer.writeEndElement(); //version
						}
					}
				} else {
					if (old.getFolderId()!=null && !old.getFolderId().equals("")) {
						writer.writeEndElement(); // folder
					}
					writer.writeEndElement(); // user
 
					writer.writeStartElement("user");
					writer.writeAttribute("compteId", current.getCompteId());
					writer.writeAttribute("name", current.getCompleteUserName());
					writer.writeAttribute("login", current.getLogin());
 
					if (current.getFolderId()!=null && !current.getFolderId().equals("")) {
						writer.writeStartElement("folder");
						writer.writeAttribute("name", current.getFolderName());
						writer.writeAttribute("id", current.getFolderId());
						writer.writeAttribute("shared", current.getFolderShared());
						writer.writeAttribute("folderKeyCode", current.getFolderKeycode());
						if (current instanceof FBXAll) {
							writer.writeAttribute("fbc", ((FBXAll)current).getFbConnection());
							writer.writeAttribute("fbrw", ((FBXAll)current).getFbReadWrite());
							if (((FBXAll)current).getFbFriend()!=null && !((FBXAll)current).getFbFriend().equals((""))) {
								writer.writeAttribute("fbf", ((FBXAll)current).getFbFriend());
							}
						}
 
						if (current.getPhotoId()!=null && !current.getPhotoId().equals("")) {
							writer.writeEmptyElement("version");
							writer.writeAttribute("i", current.getPhotoVersionId());
							writer.writeAttribute("pi", current.getPhotoId());
							writer.writeAttribute("pud", current.getPhotoOriginalUploadDate());
							writer.writeAttribute("pvd", current.getPhotoVersionUploadDate());
							writer.writeAttribute("ptd", current.getPhotoTakeDate());
							if (current.getPhotoVersionFileName()!=null && !current.getPhotoVersionFileName().equals("")) {
								writer.writeAttribute("fn", current.getPhotoVersionFileName());
							}
							if (current.getPhotoVersionPictureName()!=null && !current.getPhotoVersionPictureName().equals("")) {
								writer.writeAttribute("n", current.getPhotoVersionPictureName());
							}
							writer.writeAttribute("pkc", current.getPhotoVersionKeyCode());
							writer.writeAttribute("s", current.getPhotoVersionSize());
							writer.writeAttribute("w", current.getPhotoVersionWidth());
							writer.writeAttribute("h", current.getPhotoVersionHeight());
							writer.writeAttribute("o", "1");
							//writer.writeEndElement(); // version
						}
					}
				}
				old=current;
			}
			writer.writeEndElement(); // collection
 
			writer.writeEndDocument();
 
			writer.flush();
			writer.close();
		} catch (Exception e) {
			logger.error("Erreur de génération d'un fichier XAll",e);
		}
	}
 
}

Comme vous pouvez le voir, j'ai essayé différentes implémentations de StAX : Woodstox et SJSXP, l'implémentation qu'on trouve dans Java 6.

Le code s'exécute sur une serveur Resin Pro 3.1.6, avec un JDK 1.6_14 sur un serveur Debian.

Quand je soumets ce code à une forte charge, tout pète. Je me retrouve avec des OutOfMemoryError avec dépassement du heap space. Si quelqu'un a une idée, elle est la très bienvenue !

**Morbo** · 27/10/2010, 21h29

Hello,
Ben, je doute que la fuite vienne de la serialization puisqu'elle persiste que ce soit en JDom ou Stax. Regarde plutôt du coté de tes objets "métiers" (com.pixvisio.icontact.*), tes accesseurs qui sont beaucoup utilisés ici, tes caches....
Heapdump est ton ami.

**Traroth2** · 28/10/2010, 09h03

Le problème, c'est que les objets métier sont en production depuis 3 ans, eux. Jusqu'à présent, j'utilisais une jsp pour générer du xml de manière on ne peut moins propre, et aussi de manière on ne peut plus résistante à la charge. Mais fondamentalement, la manière de générer le XML est la seule chose qui a changé...

Fuite mémoire

Format d'échange (XML, JSON...) Java

Vue hybride

Discussions similaires

Partager

Partager