[MultiPartConfig] Limiter la taille de fichiers téléversés

**abysr** · 17/01/2016, 17h07

Bonjour, j'utilise l'annotation suivante au afin de télévérser des fichiers :

Code :

Sélectionner tout - Visualiser dans une fenêtre à part

1
2
3
4
5
 
@MultipartConfig(fileSizeThreshold=1024*100, // 100kB
                 maxFileSize=1024*512,      // 512 kB
                 maxRequestSize=1024*1024*2)   // 2MB
public class UploadForm {.....}

Je ne sais pas pourquoi, mais il ne devrait pas etre possible de uploader des fichiers superieur à : 512 k, pourtant , "ils passent quand meme" sans lever d'exception...
Et je ne sais pas trop pourquoi! de l'aide serait la bienvenue, merci @ plus

**tchize_** · 18/01/2016, 03h28

On peux voir la classe complète et le web.xml correspondant?

**abysr** · 18/01/2016, 07h51

La classe :

Code :

Sélectionner tout - Visualiser dans une fenêtre à part

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
package com.abysr.tim.business;
 
import java.io.File;
import java.io.FileInputStream;
import java.io.IOException;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
 
import javax.servlet.ServletContext;
import javax.servlet.ServletException;
import javax.servlet.annotation.MultipartConfig;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
import javax.servlet.http.HttpSession;
import javax.servlet.http.Part;
 
import org.apache.commons.fileupload.FileItem;
import org.apache.commons.fileupload.disk.DiskFileItemFactory;
import org.apache.commons.fileupload.servlet.ServletFileUpload;
import org.apache.commons.io.FilenameUtils;
 
import com.abysr.tim.model.Day;
import com.abysr.tim.service.DayService;
 
 
 
 
 
@MultipartConfig(fileSizeThreshold=1024*100, // 100kB
                 maxFileSize=1024*512,      // 512 kB
                 maxRequestSize=1024*1024*2)   // 20MB
public class UploadForm {
	private final String SUB_DIRECTORY ="pictures";
	 private final String UPLOAD_DIRECTORY = "/home/abysr/timProject" +File.separator + SUB_DIRECTORY;
	 private Integer id;
 
 
	private Map<String, String> errors = new HashMap<String, String>();
 
	public synchronized String uploadPic(HttpServletRequest request){
		HttpSession session = request.getSession();
		id  = Integer.parseInt((String) session.getAttribute("dayNum"));
		//String pathDir = request.getServletContext().getRealPath("/img");
		//System.out.println("path dir : " + pathDir);
		 String name = "";
 
 
    if(ServletFileUpload.isMultipartContent(request)){
 
 
       try
       {
    	   availableDay();
       }
       catch (Exception e)
 
       {
    	   setErrors("available", e.getMessage());
       }
    	try {
            List<FileItem> multiparts = new ServletFileUpload(
                                     new DiskFileItemFactory()).parseRequest(request);
 
            for(FileItem item : multiparts){
                if(!item.isFormField()){
                    name = new File(item.getName().trim()).getName();
                    name = name.replaceAll("\\s+","");
                    System.out.println(name);
 
 
                    try{
                    getMimeType(item, request);
                    }
                    catch (Exception e)
                    {
                    	System.out.println("erreur " + e.getMessage());
                    	setErrors("mime", e.getMessage());
                    }
 
                    if(errors.isEmpty())
                    {                  
                    item.write( new File(UPLOAD_DIRECTORY + File.separator + name)); 
                    }
 
                  }
            }
 
        } catch (Exception ex) {
        	setErrors("typeUpload", ex.getMessage());
        }          
 
    }else{
        setErrors("fileUpload",  "Sorry this Servlet only handles file upload request");
    }
 
   return (UPLOAD_DIRECTORY + File.separator + name);
 
 
}
 
 
	private void availableDay() throws Exception
	{
		 Day day = new Day();
		 DayService ds = new DayService();
		 day = ds.findById(id);
		 System.out.println(day.isAvailable());
		 if (!day.isAvailable())
		 {
			 throw new Exception("Sorry but this day is not available, someone was faster than you");
		 }
 
	}
 
private void getMimeType(FileItem item, HttpServletRequest request) throws Exception {
	 String fileName = item.getName();
 
     String mimeType = request.getServletContext().getMimeType(fileName);
	 System.out.println("mime type  : " + mimeType);
     if(mimeType != null){
 
     if (!mimeType.startsWith("image/jpeg") && !mimeType.startsWith("image/jpg") && !mimeType.startsWith("image/png") &&!mimeType.startsWith("image/gif")) {
         throw new Exception("Only jpeg, jpg, png, or gif pictures are accepted");	
	}
     }
     else
     {
    	 throw new Exception("Please select a file");
     }
 
}
 
	public String getUPLOAD_DIRECTORY() {
		return UPLOAD_DIRECTORY;
	}
 
 
 
	public Map<String, String> getErrors() {
		return errors;
	}
 
 
 
	public void setErrors(String field, String error) {
		errors.put(field, error);
	}
 
}

Puis le web.xml

Code :

Sélectionner tout - Visualiser dans une fenêtre à part

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
<?xml version="1.0" encoding="UTF-8"?>
<web-app xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://xmlns.jcp.org/xml/ns/javaee" xsi:schemaLocation="http://xmlns.jcp.org/xml/ns/javaee http://xmlns.jcp.org/xml/ns/javaee/web-app_3_1.xsd" metadata-complete="true" version="3.1">
  <absolute-ordering/>
  <welcome-file-list>
  <welcome-file>welcome.jsp</welcome-file>
 
  </welcome-file-list>
  <resource-env-ref>
    <resource-env-ref-name>jdbc/tim</resource-env-ref-name>
    <resource-env-ref-type>javax.sql.DataSource</resource-env-ref-type>
  </resource-env-ref>
  <context-param>
    <param-name>pictures_directory</param-name>
    <param-value>/home/abysr/timProject/pictures</param-value>
  </context-param>
  <listener>
    <listener-class>com.abysr.tim.util.TimContextListener</listener-class>
  </listener>
   <filter>
        <filter-name>FilterPic</filter-name>
        <filter-class>com.abysr.tim.filter.FilterPic</filter-class>
    </filter>
 
    <filter-mapping>
        <filter-name>FilterPic</filter-name>
        <url-pattern>/hookPath/*</url-pattern>
    </filter-mapping>
  <servlet>
    <servlet-name>Subscription</servlet-name>
    <servlet-class>com.abysr.tim.servlet.Subscription</servlet-class>
  </servlet>
  <servlet-mapping>
    <servlet-name>Subscription</servlet-name>
    <url-pattern>/subscription</url-pattern>
  </servlet-mapping>
  <servlet>
    <servlet-name>Connexion</servlet-name>
    <servlet-class>com.abysr.tim.servlet.Connexion</servlet-class>
  </servlet>
  <servlet-mapping>
    <servlet-name>Connexion</servlet-name>
    <url-pattern>/connexion</url-pattern>
  </servlet-mapping>
  <servlet>
    <servlet-name>Market</servlet-name>
    <servlet-class>com.abysr.tim.servlet.Market</servlet-class>
  </servlet>
  <servlet-mapping>
    <servlet-name>Market</servlet-name>
    <url-pattern>/market</url-pattern>
  </servlet-mapping>
  <servlet>
    <servlet-name>Disconnect</servlet-name>
    <servlet-class>com.abysr.tim.servlet.Disconnect</servlet-class>
  </servlet>
  <servlet-mapping>
    <servlet-name>Disconnect</servlet-name>
    <url-pattern>/disconnect</url-pattern>
  </servlet-mapping>
  <servlet>
    <servlet-name>Transaction</servlet-name>
    <servlet-class>com.abysr.tim.servlet.Transaction</servlet-class>
  </servlet>
  <servlet-mapping>
    <servlet-name>Transaction</servlet-name>
    <url-pattern>/transaction</url-pattern>
  </servlet-mapping>
  <servlet>
    <servlet-name>UploadChoice</servlet-name>
    <servlet-class>com.abysr.tim.servlet.UploadChoice</servlet-class>
  </servlet>
  <servlet-mapping>
    <servlet-name>UploadChoice</servlet-name>
    <url-pattern>/uploadChoice</url-pattern>
  </servlet-mapping>
  <servlet>
    <servlet-name>UploadSaying</servlet-name>
    <servlet-class>com.abysr.tim.servlet.UploadSaying</servlet-class>
  </servlet>
  <servlet-mapping>
    <servlet-name>UploadSaying</servlet-name>
    <url-pattern>/uploadSaying</url-pattern>
  </servlet-mapping>
  <servlet>
    <servlet-name>PicUpload</servlet-name>
    <servlet-class>com.abysr.tim.servlet.PicUpload</servlet-class>
  </servlet>
  <servlet-mapping>
    <servlet-name>PicUpload</servlet-name>
    <url-pattern>/picUpload</url-pattern>
  </servlet-mapping>
 <servlet>
    <servlet-name>FindPic</servlet-name>
    <servlet-class>com.abysr.tim.servlet.FindPic</servlet-class>
  </servlet>
  <servlet-mapping>
    <servlet-name>FindPic</servlet-name>
    <url-pattern>/findPic</url-pattern>
  </servlet-mapping>
</web-app>

et voila la servlet associée a mon objet metier UploadForm:

Code :

Sélectionner tout - Visualiser dans une fenêtre à part

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
package com.abysr.tim.servlet;
 
 import java.io.IOException;
import java.util.Map.Entry;
 
import javax.servlet.ServletException;
import javax.servlet.annotation.MultipartConfig;
import javax.servlet.http.HttpServlet;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
import javax.servlet.http.HttpSession;
 
import com.abysr.tim.business.TransactionSave;
import com.abysr.tim.business.UploadForm;
import com.abysr.tim.model.Customer;
 
@MultipartConfig(fileSizeThreshold=1024*100, // 100kB
maxFileSize=1024*512,      // 512 kB
maxRequestSize=1024*1024*2)   
public class PicUpload extends HttpServlet {
 
	private static final long serialVersionUID = 1L;
 
 
 
	@Override
    protected void doGet(HttpServletRequest request, HttpServletResponse response)
            throws ServletException, IOException {
		String view = "";
		String result = "";
 
		HttpSession session = request.getSession();
		if(session.getAttribute("customerSession") != null)
		{
			view ="/WEB-INF/uploadPicture.jsp";
 
		}
		else{
			view ="/welcome.jsp";
			result= "You have to subscribe or connect if you want go to the market place";
		}
		request.setAttribute("result", result);
	this.getServletContext().getRequestDispatcher(view).forward(request, response);
	 }
 
 
 
    @Override
    protected void doPost(HttpServletRequest request, HttpServletResponse response)
            throws ServletException, IOException {
 
    	HttpSession session =request.getSession();  
    	Customer c = (Customer) session.getAttribute("customerSession");
    	if ( c.getCustomerAccount() < 5 || session.getAttribute("customerSession") == null)
    	{
    		response.sendRedirect("http://sante.toutcomment.com/article/comment-soigner-la-cleptomanie-1666.html");
    	}
    	else{
    	UploadForm form = new UploadForm();
     String url  = form.uploadPic(request);
    	if(form.getErrors().isEmpty())
    	{
 
    		session.setAttribute("urlPic", url);
    		TransactionSave transactionSave = new TransactionSave();
    		transactionSave.createTransaction(request);
    		response.sendRedirect("market");
    	}
    	else
    	{
    		request.setAttribute("form", form);
 
 
    		this.getServletContext().getRequestDispatcher("/WEB-INF/uploadPicture.jsp").forward(request, response);
    	}
 
    }   	
 
}
 
}

**tchize_** · 18/01/2016, 10h56

Avec ton code, tu bypasse le serveur et tu traite directement le flux de la requête via common Http file upload. Ce dernier ne connait pas tes annotation. Avec les versions récentede javaee, utilise request.getPart() et oublie jusqu'à l'existence de commons fileupload qui sert pour les ancien conteneur où il n'y avait pas de support pour le multipart.

http://docs.oracle.com/javaee/6/tutorial/doc/glraq.html

[MultiPartConfig] Limiter la taille de fichiers téléversés

Java EE

Discussions similaires

Partager

Partager