Probleme Test d'integration Mockito
Bonjour a tous,
Je suis bloqué sur une test que je dois déboguer (exercice donné par notre prof).
C'est un exercice sur un parking.
Le premier test doit tester que le véhicule qui entre est bien enregistré dans la base de donnée et que la place utilisée est mise a jour dans le système (False).
Je bloque sur le second test qui doit effectuer un test lorsque le véhicule sort, on doit vérifier que l'heure de sortie est bien enregistrée et que le prix est correctement généré.
Mon test1 est bien validé, par contre mon test 2 ne passe pas pour un problème de temps lié au temps d’exécution du programme (entre 4 sec et 20 sec de différence ), ce qui fait que le prix n'est plus exacte, 1.5, mais 1.500000416666666668 du fait que mon calcul prends en compte une date en currentTimeMillis et les secondes sont comptés....
Certains paramètres nous sont donnés, donc imposés.... je les ai notés en italique
Voici ma class de test.
Pouvez-vous me donner un coup de main SVP ?
Code:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
| package com.parkit.parkingsystem.integration;
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.ArgumentMatchers.anyString;
import static org.mockito.Mockito.when;
import java.util.Date;
import org.junit.jupiter.api.AfterAll;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.ExtendWith;
import org.mockito.Mock;
import org.mockito.Mockito;
import org.mockito.junit.jupiter.MockitoExtension;
import com.parkit.parkingsystem.constants.ParkingType;
import com.parkit.parkingsystem.dao.ParkingSpotDAO;
import com.parkit.parkingsystem.dao.TicketDAO;
import com.parkit.parkingsystem.integration.config.DataBaseTestConfig;
import com.parkit.parkingsystem.integration.service.DataBasePrepareService;
import com.parkit.parkingsystem.model.ParkingSpot;
import com.parkit.parkingsystem.model.Ticket;
import com.parkit.parkingsystem.service.ParkingService;
import com.parkit.parkingsystem.util.InputReaderUtil;
@ExtendWith(MockitoExtension.class)
public class ParkingDataBaseIT {
private static final String VehiculeRegNumber = "ABCDEF";
private static DataBaseTestConfig dataBaseTestConfig = new DataBaseTestConfig();
private static DataBasePrepareService dataBasePrepareService;
@Mock
private static ParkingSpotDAO parkingSpotDAO;
@Mock
private static TicketDAO ticketDAO;
@Mock
private static Ticket ticket;
@Mock
private static InputReaderUtil inputReaderUtil;
@BeforeAll
private static void setUp() throws Exception {
// parkingSpotDAO = new ParkingSpotDAO();
// parkingSpotDAO.dataBaseConfig = dataBaseTestConfig;
// ticketDAO = new TicketDAO();
// ticketDAO.dataBaseConfig = dataBaseTestConfig;
dataBasePrepareService = new DataBasePrepareService();
}
@AfterAll
private static void tearDown() {
}
@BeforeEach
private void setUpPerTest() throws Exception {
when(inputReaderUtil.readSelection()).thenReturn(1);
when(inputReaderUtil.readVehicleRegistrationNumber()).thenReturn(VehiculeRegNumber);
dataBasePrepareService.clearDataBaseEntries();
}
@Test
public void testParkingACar() {
ParkingService parkingService = new ParkingService(inputReaderUtil, parkingSpotDAO, ticketDAO);
Mockito.when(parkingSpotDAO.getNextAvailableSlot(Mockito.any())).thenReturn(1);
parkingService.processIncomingVehicle();
Mockito.verify(ticketDAO).saveTicket(Mockito.any(Ticket.class));
Mockito.verify(parkingSpotDAO).updateParking(Mockito.any(ParkingSpot.class));
// TODO: check that a ticket is actually saved in DB and Parking table is
// updated with availability
}
@Test
public void testParkingLotExit() {
ParkingSpot parkingSpot = new ParkingSpot(1, ParkingType.CAR, false);
Ticket ticket = new Ticket();
ticket.setParkingSpot(parkingSpot);
ticket.setVehicleRegNumber(VehiculeRegNumber);
ticket.setPrice(0);
ticket.setInTime(new Date(System.currentTimeMillis() - (60 * 60 * 1000)));
ticket.setOutTime(new Date());
ticketDAO.saveTicket(ticket);
Mockito.when(ticketDAO.getTicket(anyString())).thenReturn(ticket);
Mockito.when(ticketDAO.updateTicket(any(Ticket.class))).thenReturn(true);
Mockito.when(parkingSpotDAO.updateParking(any(ParkingSpot.class))).thenReturn(true);
ParkingService parkingService = new ParkingService(inputReaderUtil, parkingSpotDAO, ticketDAO);
parkingService.processExitingVehicle();
Mockito.verify(parkingSpotDAO).updateParking(Mockito.any(ParkingSpot.class));
Assertions.assertEquals(1.5, ticket.getPrice());
// TODO: check that the fare generated and out time are populated correctly in
// the database
// vérifier que le tarif généré et l'heure de départ sont correctement
// renseignés dans la base de données
}
}
org.opentest4j.AssertionFailedError: expected: <1.5> but was: <1.5000045833333333>
at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:54)
at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:195)
at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:72)
at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:67)
at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:451)
at com.parkit.parkingsystem.integration.ParkingDataBaseIT.testParkingLotExit(ParkingDataBaseIT.java:103)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.junit.platform.commons.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:532)
at org.junit.jupiter.engine.execution.ExecutableInvoker.invoke(ExecutableInvoker.java:115)
at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeTestMethod$6(TestMethodTestDescriptor.java:171)
at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:72)
at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.invokeTestMethod(TestMethodTestDescriptor.java:167)
at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:114)
at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:59)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$4(NodeTestTask.java:108)
at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:72)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:98)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:74)
at java.util.ArrayList.forEach(ArrayList.java:1259)
at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.invokeAll(SameThreadHierarchicalTestExecutorService.java:38)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$4(NodeTestTask.java:112)
at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:72)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:98)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:74)
at java.util.ArrayList.forEach(ArrayList.java:1259)
at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.invokeAll(SameThreadHierarchicalTestExecutorService.java:38)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$4(NodeTestTask.java:112)
at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:72)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:98)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:74)
at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.submit(SameThreadHierarchicalTestExecutorService.java:32)
at org.junit.platform.engine.support.hierarchical.HierarchicalTestExecutor.execute(HierarchicalTestExecutor.java:57)
at org.junit.platform.engine.support.hierarchical.HierarchicalTestEngine.execute(HierarchicalTestEngine.java:51)
at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:220)
at org.junit.platform.launcher.core.DefaultLauncher.lambda$execute$6(DefaultLauncher.java:188)
at org.junit.platform.launcher.core.DefaultLauncher.withInterceptedStreams(DefaultLauncher.java:202)
at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:181)
at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:128)
at org.eclipse.jdt.internal.junit5.runner.JUnit5TestReference.run(JUnit5TestReference.java:100)
at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:41)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:542)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:770)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:464)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:210)
Suppressed: org.mockito.exceptions.misusing.UnnecessaryStubbingException:
Unnecessary stubbings detected.
Clean & maintainable test code requires zero unnecessary code.
Following stubbings are unnecessary (click to navigate to relevant line of code):
1. -> at com.parkit.parkingsystem.integration.ParkingDataBaseIT.setUpPerTest(ParkingDataBaseIT.java:64)
Please remove unnecessary stubbings or use 'lenient' strictness. More info: javadoc for UnnecessaryStubbingException class.
at org.mockito.junit.jupiter.MockitoExtension.afterEach(MockitoExtension.java:211)
at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeAfterEachCallbacks$11(TestMethodTestDescriptor.java:218)
at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:72)
at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeAllAfterMethodsOrCallbacks$13(TestMethodTestDescriptor.java:230)
at java.util.ArrayList.forEach(ArrayList.java:1259)
at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.invokeAllAfterMethodsOrCallbacks(TestMethodTestDescriptor.java:228)
at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.invokeAfterEachCallbacks(TestMethodTestDescriptor.java:217)
at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:120)
... 31 more |
