simplifier un code php sql

Version imprimable

Bonjour, je souhaiterai modifier ce bout de code car il est beaucoup trop long

Code:

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
 
<?php
 
class Vote extends mysql
{
 
public function addDarkPoint($pseudo, $vote) {
		$pseudo  = htmlspecialchars($pseudo, ENT_QUOTES);
		$vote  = htmlspecialchars($vote, ENT_QUOTES);
 
		$dbh = mysql::getInstanceWebsite();
		$sql = "SELECT count(*) as nbPseudo
				FROM vote
				WHERE pseudo = '".$pseudo."'";
		$requete = $dbh->prepare($sql);
		$requete->execute();
 
		$row= $requete->fetch();
 
		if ($row['nbPseudo'] >= 1) {
			$sql = "SELECT *
					FROM vote
					WHERE pseudo = '".$pseudo."'";
			$requete = $dbh->prepare($sql);
 
			$row= $requete->fetch();
			$time = time(); 
			$vote1_time = $row['vote1_time'];
			$vote2_time = $row['vote2_time'];
			$vote3_time = $row['vote3_time'];
			$vote4_time = $row['vote4_time'];
			$ip_db = $row['ip'];
			$dp_db = $row['dark_point'];
 
			$reward_dp = 5;
			$new_dp = $dp_db + $reward_dp;
			$can_revote_time = 7200 + $time;
 
			if ($vote == 1) {
				if ($vote1_time <= $time) {		
					$sql = "UPDATE vote
							SET vote1_time = '".$can_revote_time."',
							dark_point = '".$new_dp."',
							vote1 = 1
							WHERE pseudo = '".$pseudo."'";
					$requete = $dbh->prepare($sql);
					$requete->execute();
			?>
			<SCRIPT type="text/javascript">
			var obj = 'window.location.replace("http://www.xtremetop100.com/in.php?site=1132304101");';
			setTimeout(obj,0);
			</SCRIPT>
			<?php	
				} else { echo 'Vous ne pouvez pas encore revoter<br />'; exit(); }
			}
 
			if ($vote == 2) {
				if ($vote2_time <= $time) {
					$sql = "UPDATE vote
							SET vote2_time = '".$can_revote_time."',
							dark_point = '".$new_dp."',
							vote2 = 1
							WHERE pseudo = '".$pseudo."'";
					$requete = $dbh->prepare($sql);
					v
			?>
			<SCRIPT type="text/javascript">
			var obj = 'window.location.replace("http://www.e-joc.info/index.php?do=votes&id=4183");';
			setTimeout(obj,0);
			</SCRIPT>
			<?php 
				}  else { echo 'Vous ne pouvez pas encore revoter<br />'; exit();}
			}
 
			if ($vote == 3) {
				if ($vote3_time <= $time) {
					$sql = "UPDATE vote
							SET vote3_time = '".$can_revote_time."',
							dark_point = '".$new_dp."',
							vote3 = 1
							WHERE pseudo = '".$pseudo."'";
					$requete = $dbh->prepare($sql);
					$requete->execute();
			?>
			<SCRIPT type="text/javascript">
			var obj = 'window.location.replace("http://topofgames.com/index.php?do=votes&id=28954");';
			setTimeout(obj,0);
			</SCRIPT> 
			<?php
				}  else { echo 'Vous ne pouvez pas encore revoter<br />'; exit();}
			}
 
			if ($vote == 4) {
				if ($vote4_time <= $time) {
					$sql = "UPDATE vote
							SET vote4_time = '".$can_revote_time."',
							dark_point = '".$new_dp."',
							vote4 = 1
							WHERE pseudo = '".$pseudo."'";
					$requete = $dbh->prepare($sql);
					$requete->execute();
			?>
			<SCRIPT type="text/javascript">
			var obj = 'window.location.replace("http://www.rpg-paradize.com/?page=vote&vote=22276");';
			setTimeout(obj,0);
			</SCRIPT> 
			<?php
				}  else { echo 'Vous ne pouvez pas encore revoter<br />'; exit(); }
			}
		}
 
		else {
			$ip = $_SERVER["REMOTE_ADDR"];
			$reward_dp = 5;
			$time = time();
			$can_revote_time = 7200 + $time;
 
			if ($vote == 1) {
				$sql = "INSERT INTO vote
						VALUES ('".$pseudo."', '".$ip."', $reward_dp, 1, '".$can_revote_time."', 0, '', 0, '', 0, '')";
				$requete = $dbh->prepare($sql);
				$requete->execute();
				header('Location: <a href="http://www.xtremetop100.com/in.php?site=1132304101&#39;);" target="_blank">http://www.xtremetop100.com/in.php?site=1132304101');</a>  
			}
 
			if ($vote == 2) {
				$sql = "INSERT INTO vote
						VALUES ('".$pseudo."', '".$ip."', $reward_dp, 0, '', 1, '".$can_revote_time."', 0, '', 0, '')";
				$requete = $dbh->prepare($sql);
				$requete->execute();
				header('Location: <a href="http://www.e-joc.info/index.php?do=votes&id=4183&#39;);" target="_blank">http://www.e-joc.info/index.php?do=votes&id=4183');</a>  
			}
 
			if ($vote == 3) {
				$sql = "INSERT INTO vote
						VALUES ('".$pseudo."', '".$ip."', $reward_dp, 0, '', 0, '', 1, '".$can_revote_time."', 0, '')";
				$requete = $dbh->prepare($sql);
				$requete->execute();
				header('http://topofgames.com/index.php?do=votes&id=28954');  
			}
 
			if ($vote == 4) {
				$sql = "INSERT INTO vote
						VALUES ('".$pseudo."', '".$ip."', $reward_dp, 0, '', 0, '', 0, '', 1, '".$can_revote_time."')";
				$requete = $dbh->prepare($sql);
				$requete->execute();
				header('http://www.rpg-paradize.com/?page=vote&vote=22276');  
			}
		}
	}
 
	public function update($pseudo)
	{
		$dbh = mysql::getInstanceWebsite();
 
		$pseudo  = htmlspecialchars($pseudo, ENT_QUOTES);
 
		$sql = "SELECT *
				FROM vote
				WHERE pseudo = '".$pseudo."'";
		$requete = $dbh->prepare($sql);
		$requete->execute();
 
		$row= $requete->fetch();
		$time = time(); 
		$vote_time1 = $row['vote1_time'];
		$vote_time2 = $row['vote2_time'];
		$vote_time3 = $row['vote3_time'];
 
			if ($vote_time1 < $time) {
				$sql = "UPDATE vote
							SET vote1_time = 1,
							vote1 = 0
							WHERE pseudo = '".$pseudo."'";
				$requete = $dbh->prepare($sql);
				$requete->execute();
			}
 
			if ($vote_time2 < $time) {
				$sql = "UPDATE vote
							SET vote2_time = 1,
							vote2 = 0
							WHERE pseudo = '".$pseudo."'";
				$requete = $dbh->prepare($sql);
				$requete->execute();
			}
 
			if ($vote_time3 < $time) {
				$sql = "UPDATE vote
							SET vote3_time = 1,
							vote3 = 0
							WHERE pseudo = '".$pseudo."'";
				$requete = $dbh->prepare($sql);
				$requete->execute();
			}
	}
 
}
 
 
//$vote = new Vote;
//$vote->addDarkPoint('vn_killer', 1);
 
//$change = new user;
//$change->changeAllPassword();
 
?>

merci encore

28/05/2017, 18h25
Invité

Bonjour,

en tout cas, ce ne sont pas les commentaires ni les explications qui allongent ton code... :weird:

D'autre part, l'important n'est pas de raccourcir un code, mais de l'optimiser.

Au minimum : renseigne-toi sur switch().

Ok donc ce code fonctionne, et optimiser les repsonse des requetes je souhaitera raccourcir mon code par ce que la on comprends rien malgres qu'il marche.

Je vous le renvoie j'ai corrigé quelque ligne de code :

Code:

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
<?php
 
class Vote extends mysql
{
 
public function addDarkPoint($pseudo, $vote) {
		$pseudo  = htmlspecialchars($pseudo, ENT_QUOTES);
		$vote  = htmlspecialchars($vote, ENT_QUOTES);
 
		$dbh = mysql::getInstanceWebsite();
		$sql = "SELECT count(*) as nbPseudo
				FROM vote
				WHERE pseudo = '".$pseudo."'";
		$requete = $dbh->prepare($sql);
		$requete->execute();
 
		$row = $requete->fetch();
 
		if ($row['nbPseudo'] >= 1) {
			$sql = "SELECT *
					FROM vote
					WHERE pseudo = '".$pseudo."'";
			$requete = $dbh->prepare($sql);
			$requete->execute();
			$row = $requete->fetch();
 
			$time = time(); 
			$vote1_time = $row['vote1_time'];
			$vote2_time = $row['vote2_time'];
			$vote3_time = $row['vote3_time'];
			$vote4_time = $row['vote4_time'];
			$ip_db = $row['ip'];
			$dp_db = $row['dark_point'];
 
			$reward_dp = 5;
			$new_dp = $dp_db + $reward_dp;
			$can_revote_time = 7200 + $time;
 
			if ($vote == 1) {
				if ($vote1_time <= $time) {		
					$sql = "UPDATE vote
							SET vote1_time = '".$can_revote_time."',
							dark_point = '".$new_dp."',
							vote1 = 1
							WHERE pseudo = '".$pseudo."'";
					$requete = $dbh->prepare($sql);
					$requete->execute();
			?>
			<SCRIPT type="text/javascript">
			var obj = 'window.location.replace("http://www.xtremetop100.com/in.php?site=1132304101");';
			setTimeout(obj,0);
			</SCRIPT>
			<?php	
				} else { echo 'Vous ne pouvez pas encore revoter<br />'; exit(); }
			}
 
			if ($vote == 2) {
				if ($vote2_time <= $time) {
					$sql = "UPDATE vote
							SET vote2_time = '".$can_revote_time."',
							dark_point = '".$new_dp."',
							vote2 = 1
							WHERE pseudo = '".$pseudo."'";
					$requete = $dbh->prepare($sql);
					$requete->execute();
			?>
			<SCRIPT type="text/javascript">
			var obj = 'window.location.replace("http://www.e-joc.info/index.php?do=votes&id=4183");';
			setTimeout(obj,0);
			</SCRIPT>
			<?php 
				}  else { echo 'Vous ne pouvez pas encore revoter<br />'; exit();}
			}
 
			if ($vote == 3) {
				if ($vote3_time <= $time) {
					$sql = "UPDATE vote
							SET vote3_time = '".$can_revote_time."',
							dark_point = '".$new_dp."',
							vote3 = 1
							WHERE pseudo = '".$pseudo."'";
					$requete = $dbh->prepare($sql);
					$requete->execute();
			?>
			<SCRIPT type="text/javascript">
			var obj = 'window.location.replace("http://topofgames.com/index.php?do=votes&id=28954");';
			setTimeout(obj,0);
			</SCRIPT> 
			<?php
				}  else { echo 'Vous ne pouvez pas encore revoter<br />'; exit();}
			}
 
			if ($vote == 4) {
				if ($vote4_time <= $time) {
					$sql = "UPDATE vote
							SET vote4_time = '".$can_revote_time."',
							dark_point = '".$new_dp."',
							vote4 = 1
							WHERE pseudo = '".$pseudo."'";
					$requete = $dbh->prepare($sql);
					$requete->execute();
			?>
			<SCRIPT type="text/javascript">
			var obj = 'window.location.replace("http://www.rpg-paradize.com/?page=vote&vote=22276");';
			setTimeout(obj,0);
			</SCRIPT> 
			<?php
				}  else { echo 'Vous ne pouvez pas encore revoter<br />'; exit(); }
			}
		}
 
		else {
			$ip = $_SERVER["REMOTE_ADDR"];
			$reward_dp = 5;
			$time = time();
			$can_revote_time = 7200 + $time;
 
			if ($vote == 1)
			{
				$dbh1 = mysql::getInstanceWebsite(); 
				$sql1 = "INSERT INTO vote
						(pseudo, ip, vote1_time, vote1, vote2_time, vote2, vote3_time, vote3, vote4_time, vote4, dark_point)
						 VALUES ('".$pseudo."', '".$ip."', '".$can_revote_time."', 1, '', 0, '', 0, '', 0, '$reward_dp')";
				$requete1 = $dbh1->prepare($sql1);
				$requete1->execute();
				header('Location: http://www.xtremetop100.com/in.php?site=1132304101');  
			}
 
			if ($vote == 2) {
				$sql1 = "INSERT INTO vote
						(pseudo, ip, vote1_time, vote1, vote2_time, vote2, vote3_time, vote3, vote4_time, vote4, dark_point)
						 VALUES ('".$pseudo."', '".$ip."', '', 0, '$can_revote_time', 0, '', 0, '', 0, '$reward_dp')";
				$requete->execute();
				header('Location: http://www.e-joc.info/index.php?do=votes&id=4183');  
			}
 
			if ($vote == 3) {
				$sql1 = "INSERT INTO vote
						(pseudo, ip, vote1_time, vote1, vote2_time, vote2, vote3_time, vote3, vote4_time, vote4, dark_point)
						 VALUES ('".$pseudo."', '".$ip."', '', 0, '', '$can_revote_time', 1, '', 0, '$reward_dp')";
				$requete->execute();
				header('http://topofgames.com/index.php?do=votes&id=28954');  
			}
 
			if ($vote == 4) {
				$sql1 = "INSERT INTO vote
						(pseudo, ip, vote1_time, vote1, vote2_time, vote2, vote3_time, vote3, vote4_time, vote4, dark_point)
						 VALUES ('".$pseudo."', '".$ip."', '', 0, '', '', '0', '$can_revote_time', '1', '$reward_dp')";
						 $requete = $dbh->prepare($sql);
				$requete->execute();
				header('http://www.rpg-paradize.com/?page=vote&vote=22276');  
			}
		}
	}

Donc pourriez vous l'aider svp ?

28/05/2017, 19h22
Invité

1/ je t'ai déjà donné une piste

2/ mets des commentaires dans ton code !
Au moins, ça te permettra de le comprendre, et de pouvoir le maintenir dans plusieurs mois ou années.