object references an unsaved transient instance - save the transient

Version imprimable

1 pièce(s) jointe(s)

Bonjour,

J'ai le mapping suivant :

Pièce jointe 140696

Code:

1
2
3
4
5
6
7
8
9
10
@Entity
@Table(name = "authorities")
public class Authorities implements Serializable {
 
    @EmbeddedId
    protected AuthoritiesPK authoritiesPK;
 
    @ManyToOne
    @JoinColumn(name = "username", insertable = false, updatable = false)
    private Users users;

Code:

1
2
3
4
5
6
7
@Embeddable
public class AuthoritiesPK implements Serializable {
 
    @Column(name = "username")
    private String username;
    @Column(name = "authority")
    private String authority;

Code:

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
@Entity
@Table(name = "users")
public class Users implements Serializable {
 
    @Id
    @Column(name = "username")
    private String username;
    @Column(name = "password")
    private String password;
    @Column(name = "enabled")
    private Boolean enabled;
    @Column(name = "email")
    private String email;
 
    @OneToMany(mappedBy = "users", cascade = CascadeType.ALL, fetch = FetchType.LAZY)
    private List<Authorities> authoritiesList;

J'ai l’erreur suivante quand je modifie un utilisateur ?

org.hibernate.TransientObjectException: object references an unsaved transient instance - save the transient instance before flushing: entity.Authorities.users -> entity.Users

Code:

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
 
    public Users modifyUser(Users pUser, List<String> listAuthorities) {
 
        EntityTransaction tx = getEM().getTransaction();
        tx.begin();
        if (pUser.getAuthoritiesList() != null) {
 
            List<Authorities> authoritieses = pUser.getAuthoritiesList();
            for (Authorities a : authoritieses) {
                a.setUsers(null);
                getEM().remove(a);
            }
            pUser.getAuthoritiesList().clear();
            for (String authoritie : listAuthorities) {
                addAuthorities(authoritie, pUser);
            }
            pUser = getEM().merge(pUser);
 
        }
        getEM().remove(pUser);
        tx.commit();
        return pUser;
    }

17/03/2014, 18h05
tchize_

a quoi ressemble addAuthorities ?

Code:

1
2
3
4
5
6
private void addAuthorities(String authoritie, Users users) {
        AuthoritiesPK authoritiesPK = new AuthoritiesPK(users.getUsername(), authoritie);
        Authorities authorities = new Authorities(authoritiesPK);
        authorities.setUsers(users);
        getEM().persist(authorities);
}

18/03/2014, 10h31
tchize_

tu as l'erreur à quelle ligne?
18/03/2014, 10h50
chacalpuant1987

at dao.UserDao.addAuthorities(UserDao.java:158)
at dao.UserDao.modifyUser(UserDao.java:75)

Code:

addAuthorities(authoritie, pUser);

(75)

Code:

getEM().persist(authorities);

(158)
18/03/2014, 11h19
jeffray03

salut une petite question pourquoi fais-tu:

Code:

getEM().remove(pUser);

dans la method

Code:

public Users modifyUser(Users pUser, List<String> listAuthorities)

en passant chez moi, j´ai repris ton code, et je n´ai pas de probleme, j´ai modifié le mode de persistence, mais pas de changement explicite du code, et je n´ai aucun probleme meme pour faire un delete, car ta methode

Code:

modifyUser

delete le user. mais la aussi je n´ai aucune erreur.

Eric
18/03/2014, 11h27
chacalpuant1987

Oula c'es une erreur :( je veux le modifier !

donc je dois faire getEM().merge(pUser); ?

Peux-tu m'expliquer ton changement de persistance ?

Merci

en principe tu ne dois fonctionner qu´avec les Id´s,
je m´explique:
MyBean.java

Code:

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
 
  @PersistenceContext(unitName = "nom_de_ton_unit")
  private EntityManager em;
public Users modifyUser(String username, List<String> listAuthorities) {
 
       public Users modifyUser(Users pUser, List<String> listAuthorities) {
 
		if (pUser.getAuthoritiesList() != null) {
 
			List<Authorities> authoritieses = pUser.getAuthoritiesList();
			for (Authorities a : authoritieses) {
				a.setUsers(null);
				em.remove(a);
			}
			pUser.getAuthoritiesList().clear();
			for (String authoritie : listAuthorities) {
				addAuthorities(authoritie, pUser);
			}
			pUser = em.merge(pUser);
 
		}
		return pUser;
	}

et voici son appel:

Code:

1
2
3
4
5
6
7
 
  Users pUser = myBean.getUserById("testusername");
  List<String> listAuthorities = new ArrayList<String>();
   listAuthorities.add("Control");
   listAuthorities.add("Admin");
 
   myBean.modifyUser(pUser, listAuthorities);

si tu n´arrive pas a le calquer sur le tiens, je pourrais t´envoyer tout mon code.
eric

Caused by: javax.persistence.EntityExistsException: a different object with the same identifier value was already associated with the session: [entity.Authorities#entity.AuthoritiesPK[ username=romain, authority=admin ]]
at dao.UserDao.addAuthorities(UserDao.java:174) ~[classes/:na]
at dao.UserDao.modifyUser(UserDao.java:73) ~[classes/:na]

Code:

1
2
3
4
5
6
7
8
9
 public void save() {
        LOGGER.info("" + getSelectedUser().getAuthoritiesList().size());
        Users user = pUserDao.getUserByUsername(getSelectedUser().getUsername());
        pUserDao.modifyUser(user, listAuthoritiesEdit);
        String growlMessage = "The user : " + getSelectedUser().getUsername() + " has been saved";
        LOGGER.info(growlMessage);
        FacesContext.getCurrentInstance().addMessage(null,
                new FacesMessage(FacesMessage.SEVERITY_INFO, growlMessage, growlMessage));
    }

Code:

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
 public Users modifyUser(Users pUser, List<String> listAuthorities) {
 
        if (pUser.getAuthoritiesList() != null) {
 
            List<Authorities> authoritieses = pUser.getAuthoritiesList();
            for (Authorities a : authoritieses) {
                a.setUsers(null);
                getEM().remove(a);
            }
            pUser.getAuthoritiesList().clear();
            for (String authoritie : listAuthorities) {
                addAuthorities(authoritie, pUser); (ligne 73)
            }
            pUser = getEM().merge(pUser);
 
        }
        return pUser;
    }

Code:

1
2
3
4
5
6
private void addAuthorities(String authoritie, Users users) {
        AuthoritiesPK authoritiesPK = new AuthoritiesPK(users.getUsername(), authoritie);
        Authorities authorities = new Authorities(authoritiesPK);
        authorities.setUsers(users);
        getEM().persist(authorities); (ligne 174)
    }

18/03/2014, 20h37
jeffray03

si tu crees 2 sessions independante pour sauvegarder les authorities, alors tu auras toujours ce probleme.
peux-tu nous donner tout ton projet, et on va essayer de mettre cela a jour ensemble.

eric

Code:

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
public class UserDao {
 
    private static final String JPA_UNIT_NAME = "persitence";
 
    protected EntityManager em;
 
    public UserDao() {
    }
 
    public Users addUser(Users pUser, List<String> pListAuthorities) {
 
        EntityTransaction tx = getEM().getTransaction();
        tx.begin();
        getEM().persist(pUser);
        for (String authoritie : pListAuthorities) {
            addAuthorities(authoritie, pUser);
        }
        tx.commit();
        return pUser;
    }
 
    public Users modifyUser(Users pUser, List<String> listAuthorities) {
 
        if (pUser.getAuthoritiesList() != null) {
 
            List<Authorities> authoritieses = pUser.getAuthoritiesList();
            for (Authorities a : authoritieses) {
                a.setUsers(null);
                getEM().remove(a);
            }
            pUser.getAuthoritiesList().clear();
            for (String authoritie : listAuthorities) {
                addAuthorities(authoritie, pUser);
            }
            pUser = getEM().merge(pUser);
 
        }
        return pUser;
    } 
 
    public void deleteUser(Users pUser) {
 
        EntityTransaction tx = getEM().getTransaction();
        tx.begin();
        if (pUser.getAuthoritiesList() != null) {
 
            List<Authorities> authoritieses = pUser.getAuthoritiesList();
            for (Authorities a : authoritieses) {
                a.setUsers(null);
                getEM().remove(a);
            }
            pUser.getAuthoritiesList().clear();
            pUser = getEM().merge(pUser);
 
        }
 
        getEM().remove(pUser);
        tx.commit();
 
    }
 
    public List<Users> findAll() {
        List<Users> users = getEM().createQuery(
                "SELECT u FROM Users u").getResultList();
        return users;
    }
 
 
    public Users getUserByUsername(String username) {
        Users u = getEM().find(Users.class, username);
        if (u != null) {
            return u;
        } else {
            return null;
        }
 
    }
 
    protected EntityManager getEM() {
        if (em == null) {
            em = Persistence.createEntityManagerFactory(
                    JPA_UNIT_NAME).createEntityManager();
        }
        return em;
    }
 
    private void addAuthorities(String authoritie, Users users) {
        AuthoritiesPK authoritiesPK = new AuthoritiesPK(users.getUsername(), authoritie);
        Authorities authorities = new Authorities(authoritiesPK);
        authorities.setUsers(users);
        getEM().persist(authorities);
    }
}

19/03/2014, 11h19
jeffray03

salut, a ce que je vois,
tu ne ferme jamais tes connexions lorsque tu manipules les entitées,
il faut a chaque ouverture si tu fontionnes en transaction-type= "RESOURCE_LOCAL" ouvrir puis fermer la connexion.
donc:
chaque appel de :

Code:

getEM()

devrait se cloture avec un

Code:

em.close();

et si tu as ouvert une transaction avant, bien sur la fermer d´abord:

Code:

tx.close();

car avec le type transaction-type="JTA", cela se fait automatiquement lorsque tu quittes la methode.

Eric
19/03/2014, 11h33
chacalpuant1987

D'accord :) merci

Peux-tu me montrer un exemple ?

j´ai repris ton exemple:
et ca marche j´ai simplement ajouter quelques lignes:
UserDao.java

Code:

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
public class UserDao {

	private static final String JPA_UNIT_NAME = "ProjektInternet";

	protected EntityManager em;

	public UserDao() {
	}

	public Users addUser(Users pUser, List<String> pListAuthorities) {

		EntityTransaction tx = getEM().getTransaction();
		tx.begin();
		getEM().persist(pUser);
		for (String authoritie : pListAuthorities) {
			addAuthorities(authoritie, pUser);
		}
		tx.commit();

		return pUser;
	}

	public Users modifyUser(Users pUser, List<String> listAuthorities) {

		EntityTransaction tx = getEM().getTransaction();
		tx.begin();
		if (pUser.getAuthoritiesList() != null) {

			List<Authorities> authoritieses = pUser.getAuthoritiesList();
			for (Authorities a : authoritieses) {
				a.setUsers(null);
				getEM().remove(a);
			}
			pUser.getAuthoritiesList().clear();
			for (String authoritie : listAuthorities) {
				addAuthorities(authoritie, pUser);
			}
			pUser = getEM().merge(pUser);

		}
		tx.commit();
		return pUser;
	}

	public void deleteUser(Users pUser) {

		EntityTransaction tx = getEM().getTransaction();
		tx.begin();
		if (pUser.getAuthoritiesList() != null) {

			List<Authorities> authoritieses = pUser.getAuthoritiesList();
			for (Authorities a : authoritieses) {
				a.setUsers(null);
				getEM().remove(a);
			}
			pUser.getAuthoritiesList().clear();
			pUser = getEM().merge(pUser);

		}

		getEM().remove(pUser);
		tx.commit();

	}

	public List<Users> findAll() {
		List<Users> users = getEM().createQuery("SELECT u FROM Users u")
				.getResultList();
		return users;
	}

	public Users getUserByUsername(String username) {
		Users u = getEM().find(Users.class, username);
		if (u != null)
			return u;
		else
			return null;

	}

	protected EntityManager getEM() {
		if (em == null) {
			em = Persistence.createEntityManagerFactory(JPA_UNIT_NAME)
					.createEntityManager();
		}
		return em;
	}

	private void addAuthorities(String authoritie, Users users) {
		AuthoritiesPK authoritiesPK = new AuthoritiesPK(users.getUsername(),
				authoritie);
		Authorities authorities = new Authorities(authoritiesPK);
		authorities.setUsers(users);
		getEM().persist(authorities);
	}
}

MyTester.java

Code:

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
 
public class MyTester {
 
	public static void main(String[] args) {
		UserDao userDao = new UserDao();
		Users users = userDao.getUserByUsername("testusername");
		if (users != null) {
			System.out.println(users);
		}
 
		List<String> authorities = new ArrayList<String>();
		authorities.add("Convoyeur");
		authorities.add("Livreur");
		authorities.add("Administrateur");
		userDao.modifyUser(users, authorities);
		System.out.println("Operation Terminée !!!!");
	}
 
}

et sa marche aussi.
Eric

19/03/2014, 14h34
chacalpuant1987

javax.persistence.EntityExistsException: a different object with the same identifier value was already associated with the session: [entity.Authorities#entity.AuthoritiesPK[ username=soft, authority=admin ]]

Quand je met à jour une authoritie, ce n'est pas pris en compte dans la liste des utilisateurs, mais c'est ok en base ??
19/03/2014, 14h43
jeffray03

salut
comment est ce que tu as declaré ta table Authorities?
Eric

Code:

1
2
3
4
5
6
7
8
9
10
11
@Entity
@Table(name = "authorities")
public class Authorities implements Serializable {
 
 
    @EmbeddedId
    protected AuthoritiesPK authoritiesPK;
 
    @ManyToOne
    @JoinColumn(name = "username", insertable = false, updatable = false)
    private Users users;

19/03/2014, 15h21
jeffray03
comment fais-tu a la methode save(), depuis quelle interface, il se pourrait que tu manipule plusieurs données a la fois et sans close();
cela risue de te causer pas mal de probleme.
Moi je peux le faire chez mois milles fois, je n´ai pas cette erreur.
si elle persiste, alors fait un clean projet.

en passant voici comment j´ai crée ma table:
Code:

1 2 3 4 5 create table authorities( authority varchar(50), username varchar(50), primary key(authority, username));
Eric

Code:

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
 
 
@ManagedBean
@SessionScoped
public class UserController implements Serializable {
    /**
     * List authorities to a new user
     */
    private Map<String, String> authorities;
    /**
     * List authorities selected to a new user
     */
    private List<String> selectedAuthorities;
    /**
     * List authorities to edit a user
     */
    private List<String> listAuthorities = new ArrayList<String>();
    /**
     * List authorities edit to edit a user
     */
    private List<String> listAuthoritiesEdit = new ArrayList<String>();
    /**
     * List des utilisateurs
     */
    private List<Users> users;
    /**
     * Utilisateur séléctionné
     */
    private Users selectedUser = new Users();
    /**
     * DAO User
     */
    private final UserDao pUserDao = new UserDao();
    /**
     * DAO Authorities
     */
    private final AuthoritiesDao pAuthoritiesDao = new AuthoritiesDao();
    /**
     * Username addUser
     */
    private String username;
    /**
     * Username password
     */
    private String password;
    /**
     * Username email
     */
    private String email;
    /**
     * Username enabled
     */
    private Boolean enabled = true;
 
    /**
     * Constructor
     */
    public UserController() {
    }
 
    /**
     *
     */
    @PostConstruct
    public void init() {
        if (users == null) {
            users = pUserDao.findAll();
        }
        authorities = new HashMap<String, String>();
        authorities.put("extended", "extended");
        authorities.put("admin", "admin");
        authorities.put("visitor", "visitor");
 
        listAuthorities.add("admin");
        listAuthorities.add("extended");
        listAuthorities.add("visitor");
    }
 
    /**
     * addUser
     */
    public void add() {
        if (pUserDao.getUserByUsername(username) == null) {
            Users newUsers = new Users();
            newUsers.setUsername(username);
            newUsers.setPassword(password);
            newUsers.setEmail(email);
            newUsers.setEnabled(enabled);
            users.add(pUserDao.addUser(newUsers, getSelectedAuthorities()));
 
            username = "";
            password = "";
            email = "";
            enabled = true;
            selectedAuthorities = new ArrayList<String>();
 
            String growlMessage = "The user : " + newUsers.getUsername() + " has been added";
            LOGGER.info(growlMessage);
            FacesContext.getCurrentInstance().addMessage(null,
                    new FacesMessage(FacesMessage.SEVERITY_INFO, growlMessage, growlMessage));
        } else {
            String growlMessage = "The user : " + username + " already exists";
            LOGGER.info(growlMessage);
            FacesContext.getCurrentInstance().addMessage(null,
                    new FacesMessage(FacesMessage.SEVERITY_WARN, growlMessage, growlMessage));
        }
    }
 
    /**
     * saveUser
     */
    public void save() {
        LOGGER.info("" + getSelectedUser().getAuthoritiesList().size());
        Users user = pUserDao.getUserByUsername(getSelectedUser().getUsername());
        pUserDao.modifyUser(user, listAuthoritiesEdit);
        String growlMessage = "The user : " + getSelectedUser().getUsername() + " has been saved";
        LOGGER.info(growlMessage);
        FacesContext.getCurrentInstance().addMessage(null,
                new FacesMessage(FacesMessage.SEVERITY_INFO, growlMessage, growlMessage));
    }
 
    /**
     * deleteUser
     */
    public void delete() {
        pUserDao.deleteUser(getSelectedUser());
        users.remove(getSelectedUser());
        String growlMessage = "The user : " + getSelectedUser().getUsername() + " has been deleted";
        LOGGER.info(growlMessage);
        FacesContext.getCurrentInstance().addMessage(null,
                new FacesMessage(FacesMessage.SEVERITY_INFO, growlMessage, growlMessage));
    }
 
    /**
     *
     * @param pUser pUser
     * @return String authorities
     */
    public String getAuthorities(Users pUser) {
        String stringAuthorities = "";
        if (pUser != null) {
            List<Authorities> listAuthorities = pAuthoritiesDao.findAll(pUser.getUsername());
            if (listAuthorities != null) {
                for (Authorities a : listAuthorities) {
                    if (stringAuthorities.isEmpty()) {
                        stringAuthorities = stringAuthorities + a.getAuthoritiesPK().getAuthority();
                    } else {
                        stringAuthorities = stringAuthorities + ", " + a.getAuthoritiesPK().getAuthority();
                    }
                }
            }
        }
        return stringAuthorities;
    }
 
    /**
     *
     * @param pUser user
     * @return user authorities
     */
    public List<String> getListAuthorities(Users pUser) {
        if (pUser != null) {
            List<String> rsltList = new ArrayList<String>();
            List<Authorities> listAuthoritiesUser = pAuthoritiesDao.findAll(pUser.getUsername());
            if (listAuthoritiesUser != null) {
                for (Authorities a : listAuthoritiesUser) {
                    rsltList.add(a.getAuthoritiesPK().getAuthority());
                }
            }
            return rsltList;
        } else {
            return new ArrayList<String>();
        }
    }
 
    public List<Users> getUsers() {
        return users;
    }
 
    public Users getSelectedUser() {
        return selectedUser;
    }
 
    public void setSelectedUser(Users selectedUser) {
        this.selectedUser = selectedUser;
    }
 
    public String getUsername() {
        return username;
    }
 
    public void setUsername(String username) {
        this.username = username;
    }
 
    public String getPassword() {
        return password;
    }
 
    public void setPassword(String password) {
        this.password = password;
    }
 
    public String getEmail() {
        return email;
    }
 
    public void setEmail(String email) {
        this.email = email;
    }
 
    public Boolean getEnabled() {
        return enabled;
    }
 
    public void setEnabled(Boolean enabled) {
        this.enabled = enabled;
    }
 
    public Map<String, String> getAuthorities() {
        return authorities;
    }
 
    public void setAuthorities(Map<String, String> authorities) {
        this.authorities = authorities;
    }
 
    public List<String> getSelectedAuthorities() {
        return selectedAuthorities;
    }
 
    public void setListAuthoritiesEdit(List<String> listAuthoritiesEdit) {
        this.listAuthoritiesEdit = listAuthoritiesEdit;
    }
 
    /**
     *
     * @return list authorities user
     */
    public List<String> getListAuthoritiesEdit() {
        listAuthoritiesEdit = new ArrayList<String>();
        if (!getSelectedUser().equals(new Users())) {
            if (getSelectedUser().getAuthoritiesList() != null || getSelectedUser().getAuthoritiesList().isEmpty()) {
                for (Authorities a : getSelectedUser().getAuthoritiesList()) {
                    listAuthoritiesEdit.add(a.getAuthoritiesPK().getAuthority());
                }
            }
        } else {
            listAuthoritiesEdit.add("none");
        }
        return listAuthoritiesEdit;
    }
 
    public void setSelectedAuthorities(List<String> selectedAuthorities) {
        this.selectedAuthorities = selectedAuthorities;
    }
 
    public List<String> getListAuthorities() {
        return listAuthorities;
    }
 
    public void setListAuthorities(List<String> listAuthorities) {
        this.listAuthorities = listAuthorities;
    }
}

20/03/2014, 09h57
chacalpuant1987

Pas d'idée ?
20/03/2014, 11h36
jeffray03

1 pièce(s) jointe(s)

voici un testProjet realisé avec ton Code:
voir piece jointe.
20/03/2014, 17h38
chacalpuant1987

Merci,

Je suis en train de tester ton code. je te redis si cela fonctionne :)